Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform import bulk #23926

Closed
wants to merge 1 commit into from
Closed

terraform import bulk #23926

wants to merge 1 commit into from

Conversation

jarondl
Copy link

@jarondl jarondl commented Jan 22, 2020

Allow to import many different terraform resources in one command, by
supplying a list of addr,id pairs.

Basically, importing hundreds of resources takes a few hours before this
change, and a few mintues after it.

To make implementation somewhat easier I have taken out a chunk of the
mapping from args to targets into a smaller function, but the rest stays
almost the same. Some error messages change a bit.

Fixes #22219

Allow to import many different terraform resources in one command, by
supplying a list of addr,id pairs.

Basically, importing hundreds of resources takes a few hours before this
cl, and a few mintues after it.

To make implementation somewhat easier I have taken out a chunk of the
mapping from args to targets into a smaller function, but the rest stays
almost the same. Some error messages change a bit.

Fixes hashicorp#22219
@hashicorp-cla
Copy link

hashicorp-cla commented Jan 22, 2020

CLA assistant check
All committers have signed the CLA.

@jarondl
Copy link
Author

jarondl commented Feb 19, 2020

Hi @apparentlymart Can you take a look? This shortens the import for us from 3 hours to a few minutes.

@dudemcbacon
Copy link

Any chance someone could take a peak at this? We're in a similar boat, our imports take about four hours.

@yehudacohen
Copy link

Hi @apparentlymart would be great if someone could merge this pull request even as a temporary fix if you're planning on something different. We have imports that take days to complete which could be completed in less than an hour.

@tmccombs
Copy link
Contributor

tmccombs commented Jun 3, 2020

how does this compare to #22227?

@logachev
Copy link

Any updates on this?

@mildwonkey
Copy link
Contributor

Hi, and sorry for the long silence on this PR. @jarondl , thank you for submitting this. We are absolutely aware that bulk import is an important feature request, and the Terraform Core team hopes to spend some time focusing on the import design in general, so we are not going to accept any new features at this time. Thanks for putting in the effort!

@mildwonkey mildwonkey closed this Oct 1, 2020
@ghost
Copy link

ghost commented Nov 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to import in bulk
7 participants