Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue pushing the Path calls out of the Resource and Provider types #24346

Merged
merged 4 commits into from
Mar 11, 2020
Merged

Continue pushing the Path calls out of the Resource and Provider types #24346

merged 4 commits into from
Mar 11, 2020
+338 −372

Commits on Mar 11, 2020

  1. remove GraphNodeModuleInstance from Resource types 

    Remove the requirement for most *Resource types to be a
GraphNodeModuleInstance, ensuring that they never call ctx.Path while
being evaluated. This gets rid of most of the direct need for the Path
method currently implemented by NodeResourceAbstract, leaving the
provider and schema related calls for a subsequent PR.
    @jbardin
    jbardin committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    fae5f99 View commit details
    Browse the repository at this point in the history

  2. AbsProviderConfig to use addrs.Module 

    Change ModuleInstance to Module in AbsProviderConfig, because providers
need to be handled before module expansion, and should not be used
defined inside an expanded module at all.

Renaming of the addrs type can happen later, when there's less work
in-flight around provider configuration.
    @jbardin
    jbardin committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    8497adc View commit details
    Browse the repository at this point in the history

  3. convert /terraform to use new provider config 

    Change all ModuleInstances in provider types to plain Modules
    @jbardin
    jbardin committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    98cfb51 View commit details
    Browse the repository at this point in the history

  4. finish provider ModuleInstance replacement

    @jbardin
    jbardin committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    e13eecb View commit details
    Browse the repository at this point in the history