Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hcl and go-cty dependencies #26585

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Update hcl and go-cty dependencies #26585

merged 2 commits into from
Oct 14, 2020

Conversation

alisdair
Copy link
Contributor

@alisdair alisdair commented Oct 14, 2020

Update hcl to v2.7.0 and go-cty to latest commit. These changes support the sensitive variable work in 0.14.

Fixes #25326

hcl v2.7.0 changelog

Enhancements

  • json: There is a new function ParseWithStartPos, which allows overriding the starting position for parsing in case the given JSON bytes are a fragment of a larger document, such as might happen when decoding with encoding/json into a json.RawMessage. (#389)
  • json: There is a new function ParseExpression, which allows parsing a JSON string directly in expression mode, whereas previously it was only possible to parse a JSON string in body mode. (#381)
  • hclwrite: Block type now supports SetType and SetLabels, allowing surgical changes to the type and labels of an existing block without having to reconstruct the entire block. (#340)

Bugs Fixed

  • hclsyntax: Fix confusing error message for bitwise OR operator (#380)
  • hclsyntax: Several bug fixes for using HCL with values containing cty "marks" (#404, #406, #407)

go-cty changelog

  • function: Unless a parameter has AllowMarks: true explicitly set, the functions infrastructure will now guarantee that it never sees a marked value even if the mark is deep inside a data structure. Previously that guarantee was only shallow for the top-level value, similar to AllowUnknown, but because marks are a relatively new addition to cty and numerous existing functions are not written to deal with them this is the more conservative and robust default. (#72)
  • function/stdlib: The formatdate function was not correctly handling literal sequences at the end of the format string. It will now handle those as intended. (#69)

@alisdair alisdair requested a review from a team October 14, 2020 14:23
@alisdair alisdair self-assigned this Oct 14, 2020
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #26585 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted Files Coverage Δ
terraform/evaluate.go 49.66% <0.00%> (-0.45%) ⬇️
dag/walk.go 92.30% <0.00%> (+0.69%) ⬆️

@alisdair alisdair merged commit b1500db into master Oct 14, 2020
@alisdair alisdair deleted the alisdair/update-hcl-cty branch October 14, 2020 17:42
@ghost
Copy link

ghost commented Nov 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error message: "Bitwise operators are not supported. Did you mean boolean OR ("&&")?"
2 participants