command/jsonprovider: bump format version #28115
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for attributes with NestedTypes was added in #28055, and should have included a format version bump: this is a backwards-compatible change, but consumers will need to be updated in order to properly decode attributes (with NestedTypes) going forward.
radeksimko
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
LGTM, I already have a draft PR, so I'll just reflect this version change there.
I reckon instead of string-matching the version we'll need to start parsing it as semver and check if it's =< than supported (0.2) and then continue erroring in the unmarshaller if it's not. Alternatively we can continue exact-matching it and have a slice of two strings. 🤷🏻♂️
paddycarver
approved these changes
Mar 16, 2021
vancluever
approved these changes
Mar 16, 2021
mildwonkey
added
the
0.15-backport
alisdair
approved these changes
Mar 22, 2021
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for attributes with NestedTypes was added in #28055, and that PR should have included a format version bump: this is a backwards-compatible change, but consumers will need to be updated in order to properly decode attributes (with NestedTypes) going forward.
Thanks @bflad for the nudge!
@vancluever , I am sorry I did not include you on the last PR (#28055); if you have questions / see any problems / have any requests I'll get right on 'em.