Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailing -chdir behavior with terraform.d/plugin folders #31460

Merged

Conversation

fnickels
Copy link
Contributor

@crw
Copy link
Collaborator

crw commented Jul 21, 2022

Thanks for these documentation changes. I'll run these past the docs team for review.

Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fnickels - thanks for adding this! I'm making a suggested edit to help with clarity and flow. Please let me know if I have misunderstood your intended meaning. Do you feel comfortable merging it in?

@crw After this, I would like a quick engineering technical 👍 as well - this is a case I'm not super familiar with and I want to make sure engineering is okay with this. Especially since there has been discussion about -chdir in other threads. Thank you!

website/docs/cli/config/config-file.mdx Outdated Show resolved Hide resolved
@laurapacilio laurapacilio added the tw-reviewed Technical Writing has reviewed this PR. label Jul 22, 2022
lgtm

Co-authored-by: Laura Pacilio <83350965+laurapacilio@users.noreply.github.com>
Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 @crw - over to eng. for a final 👍

@crw
Copy link
Collaborator

crw commented Jul 27, 2022

For future reference: I believe this comment confirms the behavior as described in these docs changes. However, I'll queue this up for final review.

#31442 (comment)

@crw crw changed the title doc change to match behavior Detailing -chdir behavior with terraform.d/plugin folders Jul 27, 2022
@laurapacilio laurapacilio added the 1.2-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Jul 29, 2022
@laurapacilio laurapacilio merged commit 2b0e14d into hashicorp:main Jul 29, 2022
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.2-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged documentation tw-reviewed Technical Writing has reviewed this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants