Backport of Fix no-op outputs causing the plan renderer to skip the 'no changes' message into v1.4 #32822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teamterraform
force-pushed
the
backport/liamcervante/32815/weekly-saving-stinkbug
branch
from
2a9df21 to
42b5060
Compare
teamterraform
force-pushed
the
backport/liamcervante/32815/weekly-saving-stinkbug
branch
from
97d77a0 to
4faca62
Compare
liamcervante
approved these changes
Mar 10, 2023
liamcervante
deleted the
backport/liamcervante/32815/weekly-saving-stinkbug
branch
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #32820 to be assessed for backporting due to the inclusion of the label 1.4-backport.
The below text is copied from the body of the original PR.
Currently, we are checking whether the output changes are empty before deciding to print the "no changes" message in the renderer. But, no-op changes do not print anything so any plan with no-op changes will make the renderer consider the output changes to be not empty so it won't print the nice message but then it also won't print any outputs.
This PR fixes this by computing the concrete output diffs earlier and then using them to decide whether to print the "no changes" message.
Fixes #32815
Target Release
1.4.1
Draft CHANGELOG entry
BUG FIXES