switch to ergochat/readline

[slingamn]

This switches the Terraform console library from chzyer/readline, which is unmaintained, to a fork ergochat/readline, maintained by me and @wader.

This will fix a number of bugs, including #33195. It may also make possible Solaris support for the console, which is currently compiled out:

terraform/internal/command/console_interactive_solaris.go

Lines 18 to 20 in c42e0ee

	"The readline library Terraform currently uses for the interactive\n" +
	"console is not supported by Solaris. Interactive mode is therefore\n" +
	"not supported on Solaris currently."))

I can confirm that our fork builds with GOOS=solaris, but I don't have a Solaris environment to confirm that the runtime behavior is as expected.

Fixes #33195

Target Release

1.5.x

Draft CHANGELOG entry

BUG FIXES

• terraform console: Fixed crash from Ctrl-C when searching an empty history

[hashicorp-cla]

All committers have signed the CLA.

[crw]

Thanks for this submission! To set expectations, we will need to have this reviewed by the security team and we are in the beta/RC period for 1.5 so it may be some time before this is reviewed. Thanks again!

[slingamn]

Just wanted to check in about this again?

[crw]

Thanks for the bump. I'll bring it up in triage again, to see if we want to pursue this in the near future.

[slingamn]

(Updating to our latest release, v0.1.0)

[crw]

Thanks for this. We are going to work on a process for updating dependencies before new releases. I'll keep you posted.