Bump aws-sdk-go from 1.44.122 to 1.44.298

[johnnywalker]

Upgrade aws-sdk-go to v1.44.298, which enables support for Identity Center/SSO.

Ref: https://github.com/aws/aws-sdk-go/releases/tag/v1.44.298

Fixes #32448
Fixes #32465

Target Release

1.5.x

Draft CHANGELOG entry

Bump aws-sdk-go from 1.44.122 to 1.44.298 (support SSO in AWS backend)

BUG FIXES

When using the aws backend, Terraform no longer throws:

╷
│ Error: error configuring S3 Backend: Error creating AWS session: profile "xxx" is configured to use SSO but is missing required configuration: sso_region, sso_start_url
│ 
│ 
╵

[hashicorp-cla]

All committers have signed the CLA.

[crw]

Thanks for this submission! I'll raise it in triage.

[johnnywalker]

Very welcome! Thanks for taking a look.

[crw]

As this library is only used by this backend, it has been referred to the AWS Provider team for review. Thanks!

[johnnywalker]

@crw Sorry for the confusion, but my PR should have targeted v1.5 instead of main. I've updated the base and fork accordingly.

[crw]

@johnnywalker have you seen this PR / thread as well? I think we can probably close this PR as the work will be done in stages by the provider team - what do you think?

#33469 (comment)

[johnnywalker]

@crw Yes sir I took a look at that but wasn't sure about the timeline. In particular, that comment mentions rolling out the change with several releases, so I assume it's a bit more protracted.

This PR effectively backports SSO support for the S3 backend to v1.5 and can be used immediately. I'm running it locally and thoroughly enjoying the SSO support! If others agree, I think it would be very helpful to merge this to v1.5 in the interim.

[crw]

Interesting. It may be problematic merging only to 1.5 - if the other change isn't baked by the time 1.6 rolls out, then this feature would regress. In any case, I will leave this PR open for the AWS provider team to review as they have time.

[michailw]

Just leaving the note - the AWS provider team merged the same bump on the AWS provider side and released it with the 5.8.0 version of the AWS provider.

hashicorp/terraform-provider-aws#28263
https://github.com/hashicorp/terraform-provider-aws/pull/32426/files

[crw]

@johnnywalker Just a heads-up, this would need to be merged to main (and then we would backport it to 1.5). I need to check with @gdavison to see if we can merge this without getting in the way of what he has planned - I'll follow up on that and get back to you.

[crw]

@johnnywalker Confirmed that this can be merged without impacting the upgrade to 2.x, so when you get a chance please re-target to main and I can get this reviewed and merged. Thanks!

[jBouyoud]

@crw , I just re-create a new PR on main target

[crw]

Thanks! We can move the further discussion there.

[johnnywalker]

@crw @jBouyoud Sorry for the late response. I'll continue discussion on #33607 , but I initially applied these changes to main and ran into problems using the updated version locally. Perhaps this has been resolved already, but I assumed main included work-in-progress for migrating to aws-sdk-go-v2. In particular, there are quite a few aws-sdk-go-v2 dependencies listed in go.sum now, and these originated in 9f6a3ba#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.