-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of fix(s3): allow aliases for kms key into v1.6 #34038
Backport of fix(s3): allow aliases for kms key into v1.6 #34038
Conversation
76de03f
to
49291d2
Compare
f803b3f
to
56f9f18
Compare
56f9f18
to
e46fe59
Compare
e46fe59
to
dcda361
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
% TF_ACC=1 go test -count=1 ./internal/backend/remote-state/s3/...
ok github.com/hashicorp/terraform/internal/backend/remote-state/s3 138.365s
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
@jar-b It fixes a breaking change what affects many organizations. When it will be available with a new release? Have you thought about a hotfix? |
This will be part of 1.6.1, which is planned to be released later today. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Backport
This PR is auto-generated from #33993 to be assessed for backporting due to the inclusion of the label 1.6-backport.
The below text is copied from the body of the original PR.
Release 1.6.0 broke the ability to use s3 key aliases in the s3 backend. This change adjusts the tests, and validation of kms key arn's to look for aliases
Fixes #33979
Fixes #34005
Target Release
1.6.1
Draft CHANGELOG entry
BUG FIXES
Overview of commits