Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the document with an example of Git depth. for issue#34676 #34692

Merged
merged 8 commits into from
Mar 7, 2024
Merged

Updated the document with an example of Git depth. for issue#34676 #34692

merged 8 commits into from
Mar 7, 2024

Conversation

vinod827
Copy link
Contributor

This PR fixes the issue# #34676 where the documentation was unclear to the developers concerning the git clone ---depth during shallow cloning of a git repository. It describes the git depth in detail with an example.

Fixes #
#34676

@vinod827 vinod827 mentioned this pull request Feb 17, 2024
Closed
@vinod827 @runephilosof-karnovgroup
Update website/docs/language/modules/sources.mdx
dfcb6ea 
Co-authored-by: runephilosof-karnovgroup <101270124+runephilosof-karnovgroup@users.noreply.github.com>
runephilosof-karnovgroup
runephilosof-karnovgroup reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@runephilosof-karnovgroup runephilosof-karnovgroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to also delete lines 283-285 which are now repeated in the new text.

@vinod827
Copy link
Contributor Author

vinod827 commented Mar 1, 2024

Please approve this PR

@crw
Copy link
Contributor

crw commented Mar 1, 2024

@vinod827 I've reached out to the docs team for a review. Thanks for your patience!

trujillo-adam
trujillo-adam reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. I added a few tweaks to fix the grammar.

website/docs/language/modules/sources.mdx Outdated Show resolved Hide resolved
@trujillo-adam trujillo-adam added the tw-reviewed Technical Writing has reviewed this PR. label Mar 6, 2024
@crw crw added the waiting-response An issue/pull request is waiting for a response from the community label Mar 7, 2024
@vinod827 @trujillo-adam
Update website/docs/language/modules/sources.mdx
846f170 
Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
@vinod827 vinod827 requested a review from trujillo-adam March 7, 2024 03:04
@crw crw added 1.7-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.8-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged and removed waiting-response An issue/pull request is waiting for a response from the community labels Mar 7, 2024
@crw crw merged commit 0343af6 into hashicorp:main Mar 7, 2024
6 of 7 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

This was referenced Mar 7, 2024
Closed
Closed
@kmoe kmoe mentioned this pull request Mar 7, 2024
Merged
@kmoe kmoe mentioned this pull request Mar 7, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@runephilosof-karnovgroup runephilosof-karnovgroup runephilosof-karnovgroup approved these changes

@crw crw crw approved these changes

@trujillo-adam trujillo-adam Awaiting requested review from trujillo-adam

Assignees
No one assigned
Labels
1.7-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.8-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged documentation tw-reviewed Technical Writing has reviewed this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinod827 @crw @trujillo-adam @runephilosof-karnovgroup