Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Update AWS SDK versions to the latest into v1.7 #34804

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #34796 to be assessed for backporting due to the inclusion of the label 1.7-backport.

The below text is copied from the body of the original PR.


This pull request updates the AWS SDKs to the latest version.

The intent is to fix #34528, which is intermittent and can't be easily reproduced.

The root cause was discussed in the relevant AWS SDK issue and AWS folks couldn't reproduce this situation on the latest versions of their SDK.

Hence, this pull request.

Target Release

1.7.x, 1.8.x

Draft CHANGELOG entry

BUG FIXES

  • When using s3 backend and encountering a network issue, the retry code would fail with "failed to rewind transport stream for retry". Now the retry should be successful.

Overview of commits

@kojoru
Copy link
Contributor

kojoru commented Mar 13, 2024

@gdavison hi! Sorry for bothering, but this is my first time making a pull request to terraform, and I couldn't find the supporting documentation for this.

What's the expected process from here? When and how will the backport pull request be merged? When and how will it be released?

I've noticed most other backport pull requests are merged upon approval, and that made me a bit worried about this one. I wouldn't want that change to miss the next hotfix release.

@crw
Copy link
Contributor

crw commented Mar 13, 2024

I am under the impression @gdavison should merge this PR, the backport process is basically a HashiCorp internal process as far as I am aware. @gdavison is this un-merged because we are purposefully waiting for something? If not I can also merge this. Let me know!

@jar-b jar-b merged commit 5898c1b into v1.7 Mar 13, 2024
6 checks passed
@jar-b jar-b deleted the backport/update_deps/namely-brief-leopard branch March 13, 2024 17:43
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants