Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deferred actions: implement latest provider protocol proposals #35063

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

liamcervante
Copy link
Member

This PR implements the latest proposal for the changes to the provider protocol with support for deferred actions.

We're moving the deferral_allowed field into a common ClientCapabilities message type to mirror the ServerCapabilities struct. This will make further changes of this type easier to implement in the future, as feature triggers like this can be added to the capabilities message once instead of to all the RPC requests directly.

In addition, adding it to the ConfigureProvider RPC. The ConfigureProvider response is not changing, so this is just an FYI to help the providers prepare for future deferral requests.

There is no behaviour change in this PR, the only difference is in the format we are sending the deferral_allowed field to the providers.

@DanielMSchmidt, this may break some of your in progress PRs but the fixes should be relatively trivial. Just adding in the extra ClientCapabilities wrapper.

@liamcervante liamcervante requested review from bflad, austinvalle and a team April 23, 2024 14:28
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Protocol changes look good to me, thanks! 🎸

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@liamcervante liamcervante merged commit 055dd27 into main Apr 24, 2024
6 checks passed
@liamcervante liamcervante deleted the liamcervante/deferred-actions-protocol branch April 24, 2024 12:10
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants