Optimize, then disable ResourceGraph during normal plans #35066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reducePreservingRelationships method is strictly removing nodes and passing through the connecting edges. This does not take multiple rounds if the removal is done immediately, so we can make the process much simpler.
When deferrals are not being used, don't spend time building the deferrals graph.
jbardin
added
the
1.8-backport
liamcervante
approved these changes
Apr 24, 2024
|
I'll merge this now, so we can do the release today! |
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal here is to temporarily disable the
ResourceGraphcreation during normal plans, to avoid the overhead when deferrals are not being used. The*deferring.Deferredvalue is referenced in many places now throughout core, so we make sure to replace it with a valid empty value.While we're in here, the
reducePreservingRelationshipsgets an optimization that was ready anyway. The algorithm to remove nodes can be done in a single pass when removing the nodes immediately. As each node is removed and replaced with the product of all edges, those edges will already be in place for the next steps if those new edges connect to more nodes which will be removed.