fix: skip check evaluation when context is not prepared successfully

[burnerlee]

This PR fixes the terraform test cmd logging additional errorenous error message while referencing invalid attributes. While evaluating a check, a HCL evaluation context is created for the test command. Some validation is done during the creation of the context, failing which an empty context is returned with the expected diagnostic. This PR stops the evaluation of a check as soon as a diagnostic is returned with an error.

Fixes #35265

Target Release

1.9.1

Draft CHANGELOG entry

BUG FIXES

• The terraform test command is expected to not show confusing message when context does not contain variables due to validation error
• The expected behaviour is shown for the case mentioned in the issue description:

[hashicorp-cla-app]

All committers have signed the CLA.

[burnerlee]

@liamcervante could you please review?

[liamcervante]

Looks good to me! Thanks for the contribution @burnerlee!

[github-actions]

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

[liamcervante]

Whoops, I missed this was being merged directly into the v1.8 branch. We should have merged this into main and then let the backport bot automatically push into the most recent release branch. I should have checked the target branch more carefully.

I've reverted this PR in #35410, and merged this into the correct branch in #35411. @burnerlee, the commit that lands in main should still have your Github profile associated with it 👍

[burnerlee]

Whoops, I missed this was being merged directly into the v1.8 branch. We should have merged this into main and then let the backport bot automatically push into the most recent release branch. I should have checked the target branch more carefully.

I've reverted this PR in #35410, and merged this into the correct branch in #35411. @burnerlee, the commit that lands in main should still have your Github profile associated with it 👍

oh I see, I will take care of this in the future contributions

[burnerlee]

@liamcervante, I am looking forward to making new contributions to this project. Can't find recent good-first-issues. Can you assign me some beginner-friendly/medium level issues?

[crw]

Hi @burnerlee, thanks for your contribution! We appreciate your enthusiasm, unfortunately we do not currently have a list of good first issues for community contribution. Please keep checking in for any issue marked good first issue for opportunities to contribute. Also please check out https://github.com/hashicorp/terraform/blob/main/.github/CONTRIBUTING.md, if there are updates to the Contributing process I will update that document. Thanks very much!

[burnerlee]

Hi @burnerlee, thanks for your contribution! We appreciate your enthusiasm, unfortunately we do not currently have a list of good first issues for community contribution. Please keep checking in for any issue marked good first issue for opportunities to contribute. Also please check out https://github.com/hashicorp/terraform/blob/main/.github/CONTRIBUTING.md, if there are updates to the Contributing process I will update that document. Thanks very much!

Hey @crw thanks for the reply. Can you assign me some medium level issues instead? I would be happy to go through the codebase and try to resolve those. I'm looking to be a long time contributor

[crw]

@burnerlee Unfortunately, we do not have the capacity on the team right now for managing and reviewing larger external contributions. In general, it is difficult to ramp up external contributors on the context needed to understand the impact of changing any particular system. Again, please see specifically https://github.com/hashicorp/terraform/blob/main/.github/CONTRIBUTING.md#contributing-a-pull-request for more info on how to contribute effectively. I'd strongly recommend looking at the AWS or Azure providers as a starting place to make more widespread contributions.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.