Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade github.com/hashicorp/go-retryablehttp & deps #35473

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

finnigja
Copy link
Contributor

This updates github.com/hashicorp/go-retryablehttp (addressing CVE-2024-6104) & associated dependencies (github.com/hashicorp/go-hclog and golang.org/x/sys).

Exposure to this CVE is environment/context-dependent & would require explicit usage of basic auth URLs with Terraform core. This has already been addressed in the hashicorp/http provider, where it was perhaps more likely to be exposed, with hashicorp/terraform-provider-http#429 which went out with the 3.4.3 release.

hashicorp/go-retryablehttp@v0.7.5...v0.7.7
hashicorp/go-hclog@v1.5.0...v1.6.3
golang/sys@v0.19.0...v0.20.0

This addresses https://github.com/hashicorp/terraform/security/dependabot/64 and replaces #35379.

Target Release

1.9.x

Draft CHANGELOG entry

BUG FIXES

  • Updated to newer github.com/hashicorp/go-retryablehttp version, addressing CVE-2024-6104, and bringing in updates for several indirect dependencies.

@finnigja finnigja added the 1.9-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Jul 17, 2024
@finnigja finnigja requested review from a team as code owners July 17, 2024 18:45
@finnigja finnigja requested a review from a team July 17, 2024 18:54
@finnigja finnigja merged commit 54f937c into main Jul 22, 2024
9 of 10 checks passed
@finnigja finnigja deleted the upgrade_go_retryablehttp branch July 22, 2024 17:26
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

finnigja added a commit that referenced this pull request Jul 22, 2024
…#35487)

* upgrade github.com/hashicorp/go-retryablehttp & deps
* add CHANGELOG entry
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.9-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants