-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional validation to secret_suffix
in Kubernetes backend
#35666
Add additional validation to secret_suffix
in Kubernetes backend
#35666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, following our conversation in Slack.
Deferring to @jrhouston for a second pair of eyes and final approval as he's more familiar with this code than I am.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding validation for this @bschaatsbergen – I'm going to approve, but I've left you some comments proposing some cosmetic changes to the code.
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Addresses an issue with the
secret_suffix
attribute in the Kubernetes backend. It adds a check to prevent suffixes from ending with a-<number>
, as this conflicts with the backend’s chunking mechanism that appends numeric indices to secret names.Details on the exact underlying issue and chunking mechanism can be found here : #35641 (comment)
Fixes #35641