Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overly-eager jsonencode #35984

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

bplotnick
Copy link
Contributor

@bplotnick bplotnick commented Nov 11, 2024

Fixes #35983

Target Release

1.9.9

Draft CHANGELOG entry

BUG FIXES

  • Simplify config generation (plan -generate-config-out) for string attributes that contain primitive types (e.g. numbers or booleans)

@bplotnick bplotnick requested a review from a team as a code owner November 11, 2024 16:54
@crw
Copy link
Contributor

crw commented Nov 11, 2024

Thanks for this submission, I'll raise it in triage.

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. Thanks for the PR.

internal/genconfig/generate_config_test.go Outdated Show resolved Hide resolved
@radeksimko radeksimko added the 1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Nov 13, 2024
@radeksimko radeksimko merged commit de69c22 into hashicorp:main Nov 13, 2024
6 checks passed
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config generation wraps numbers and booleans in jsonencode
3 participants