Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Treat INACTIVE ECS TDs as deleted in acc tests #4365

Merged
merged 1 commit into from
Dec 17, 2015

Conversation

radeksimko
Copy link
Member

The fix was already implemented in #3924 but I forgot to do this for tests, hence these were failing.

This PR is also fixing the following failures by using ARN instead of ID (TD family):

=== RUN   TestAccAWSEcsTaskDefinition_basic
--- FAIL: TestAccAWSEcsTaskDefinition_basic (13.57s)
    testing.go:165: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: Check failed: ClientException: Unable to describe task definition.
            status code: 400, request id: abcd123f-a434-11e5-a12c-5d8de85cf2ff

        State: <no state>
=== RUN   TestAccAWSEcsTaskDefinition_withScratchVolume
--- FAIL: TestAccAWSEcsTaskDefinition_withScratchVolume (7.91s)
    testing.go:165: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: Check failed: ClientException: Unable to describe task definition.
            status code: 400, request id: abcd123f-a434-a12c-abb1-eb4dd31a84df

        State: <no state>
=== RUN   TestAccAWSEcsTaskDefinition_withEcsService
--- FAIL: TestAccAWSEcsTaskDefinition_withEcsService (115.39s)
    testing.go:165: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: Check failed: ClientException: Unable to describe task definition.
            status code: 400, request id: abcd123f-a435-11e5-a12c-55bc0aaa1ee9

        State: <no state>

@radeksimko radeksimko changed the title aws: Treat INACTIVE ECS TDs as deleted in acc tests provider/aws: Treat INACTIVE ECS TDs as deleted in acc tests Dec 17, 2015
@phinze
Copy link
Contributor

phinze commented Dec 17, 2015

LGTM

radeksimko added a commit that referenced this pull request Dec 17, 2015
provider/aws: Treat INACTIVE ECS TDs as deleted in acc tests
@radeksimko radeksimko merged commit 8b30fd4 into hashicorp:master Dec 17, 2015
@radeksimko radeksimko deleted the b-ecs-td-fix branch December 17, 2015 16:38
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants