TLS: Adding public key to resource output #4441
Conversation
Signed-off-by: Simarpreet Singh <simar@linux.com>
|
Okay, the CI build failed. Going to look into fixing this shortly. |
Merging terraform upstream
Signed-off-by: Simarpreet Singh <simar@linux.com>
Signed-off-by: Simarpreet Singh <simar@linux.com>
Signed-off-by: Simarpreet Singh <simar@linux.com>
Signed-off-by: Simarpreet Singh <simar@linux.com>
|
yay all green! @apparentlymart, @radeksimko mind giving this a look when you have time to see if this is okay? |
Merging from upstream.
|
Hi @simar7... sorry I took so long to respond to you on this one. Thanks for working on this! I took your work here and added an additional feature of generating OpenSSH-formatted public keys so that this resource can also be used for SSH credentials. My updated patch is in #4606. Once another Terraform collaborator has reviewed it we should hopefully be able to get this merged. |
In most cases private keys are used to produce certs and cert requests, but there are some less-common cases where the PEM-formatted keypair is used alone. The public_key_pem attribute supports such cases. This also includes a public_key_openssh attribute, which allows this resource to be used to generate temporary OpenSSH credentials, so that e.g. a Terraform configuration could generate its own keypair to use with the aws_key_pair resource. This has the same caveats as all cases where we generate private keys in Terraform, but could be useful for temporary/throwaway environments where the state either doesn't live for long or is stored securely. This builds on work started by Simarpreet Singh in hashicorp#4441 .
|
@apparentlymart can you have a look at this one and see if you feel it is ready to merge now that #4606 was merged? @simar7 please can you rebase this PR and squash the commits (to make the log cleaner) so that it can be merged cleanly? Thanks |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This pull request targets: #4134
Signed-off-by: Simarpreet Singh simar@linux.com