Fix Google instance template creation for preemptible VM

[erobert-c]

Hi there,

This commit should allow the creation of preemptible instance template in google compute engine. Currently, while trying to create such template, we get the following error:

Error applying plan:

1 error(s) occurred:

* google_compute_instance_template.preentibletemplate-test: Error creating instance: googleapi: Error 400: Invalid value for field 'resource.properties.scheduling.preemptible': 'true'.  Scheduling must have preemptible be false when AutomaticRestart is true., invalid

Here is a simple template to reproduce the issue

resource "google_compute_instance_template" "preentibletemplate-test" {
  name = "preemptible-template-test"
  machine_type = "n1-standard-2"
  scheduling {
    automatic_restart = false
    preemptible = true
  }
  disk {
    source_image = "${var.base_image}"
    boot = true
  }
  network_interface {
    network = "${var.subnet_id}"
  }
}

Tests results with make test TEST=./builtin/providers/google/ are still good.

Cheers

[phinze]

This LGTM - would like a double check from @lwander to be sure though.

[lwander]

You allocate the capacity for this slice as 3, but you potentially add 4 items. This can cause runtime panic. I would recommend only placing "OnHostMaintenance" into ForceSendFields once, to avoid sending it twice.

[lwander]

Good catch and fix! Thanks for doing this @erobert-c; once you address the comments it's ready to be merged!

[erobert-c]

Hi,

Thanks for the review, I'll fix those most probably beginning of next week.

[erobert-c]

Hi @lwander,

I tried to integrate your feedbacks, squashed the commits and rebased on master. Don't hesitate to tell if you'd like me to change something else.

Cheers

[lwander]

LGTM!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.