fixes-#6198-vsphere-provider-improve-documentation #6200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| domain = "${var.vsphere_domain}" | ||
| datacenter = "${var.vsphere_datacenter}" | ||
| cluster = "${var.vsphere_cluster}" | ||
| resource_pool = "${var.vsphere_cluster}/Resources/${var.vsphere_resource_pool}" |
There was a problem hiding this comment.
AWESOME!! How about some english describing how this works?? How about when there is not a cluster? Any other use cases?
|
@tommymalmqvist any comments on my nit picks? |
|
hey @chrislovecnm, I have moved the info. Check and see what you think. 👍 |
tommymalmqvist
force-pushed
the
fixes-6198-improve-documentation-vpshere
branch
from
e0fe2df
to
0108ef7
Compare
|
Thanks @tommymalmqvist! |
|
@stack72 thanks - but what u doin working on a Sunday :P Animal!! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some confusion about using the resource_pool arument to the resource definition. This will add a more complete example.
issue 6198
#6198