[WIP] : Azure Load Balancer with separated resource #6467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buzztroll
force-pushed
the
azure/full_lb
branch
2 times, most recently
from
f593b56 to
d8489da
Compare
This implementats the azure load balancer in several resources: - azurerm_load_balancer - azurerm_load_balancer_probe - azurerm_load_balancer_backend_pool - azurerm_load_balancer_rule The frontend IP is implemented as part of the top level load balancer and thus there can only be 1 frontend IP with this implementation. This creates parity with other clouds.
|
any idea when this would be looked at ? |
|
Would these resources allow a configuration like this one? #6429 (comment) |
|
@stack72 and I have now started working on this and will see it through to completion - WIP is at #9199, and we will update that pull request as we go. Thanks for all the work so far, @buzztroll! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch shows what an implementation of the azure load balancer looks like with the resources separated. Frontend IP, probe, and rule have all been broken out into separate resources thus making 4 resources needed total with the load balancer itself.
Note that doing this causes some potentially strange events. As an example we cannot delete all of the frontend IPs from the load balancer or azure will send an error. If the user is trying to change the frontend ip set this will likely result in a delete then an add. It will be difficult to get that right.
See #6429 #6335 for alternative approaches. #6335 could be reworked to be simpler but still have nested resources.
@jen20 @phinze any thoughts?