Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for bucket name validation #7052

Closed
wants to merge 1 commit into from

Conversation

kjmkznr
Copy link
Contributor

@kjmkznr kjmkznr commented Jun 7, 2016

@catsby
Copy link
Contributor

catsby commented Jun 7, 2016

Hey @kjmkznr thanks for the PR! Does this make any accommodations for the more relaxed restrictions on Buckets in us-east-1, mentioned not that doc page? I like this validation, but we need to be flexible for people still on us-east-1 and allowed to have more relaxed names

@catsby catsby added enhancement provider/aws waiting-response An issue/pull request is waiting for a response from the community labels Jun 7, 2016
@kjmkznr
Copy link
Contributor Author

kjmkznr commented Jun 8, 2016

Yes, mentioned that doc page. And I know lax only in us-east-1 region.
I wanted this validation, I tried to put out the pull request.
And I agree to what you say.

@kjmkznr kjmkznr closed this Jun 8, 2016
@kjmkznr
Copy link
Contributor Author

kjmkznr commented Jun 8, 2016

link #6173

@catsby catsby added thinking and removed waiting-response An issue/pull request is waiting for a response from the community labels Jun 8, 2016
@catsby
Copy link
Contributor

catsby commented Jun 8, 2016

Hey @kjmkznr – I didn't mean to suggest you close your pull request, I apologize for giving that impression!

I do like this change, we just need to think on how we'd approach this, gracefully if we can. As the doc says, this will be enforced in us-east-1 eventually. For us, it's a matter of what to do with users who are currently using the relaxed names.

@kjmkznr
Copy link
Contributor Author

kjmkznr commented Jun 8, 2016

@catsby
Sorry!
I see.

It is one of the idea, What about to add a ‘ignore_validation‘ parameter?

@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants