Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding result for loadbalancer v2 VipPortID #7542

Closed
wants to merge 1 commit into from

Conversation

dkalleg
Copy link
Contributor

@dkalleg dkalleg commented Jul 7, 2016

This patch adds the VipPortID as a result of creating a lbaas v2
loadbalancer. This can be used to create a FIP. This has a dependency
on a gophercloud PR: rackspace/gophercloud#606

This patch adds the VipPortID as a result of creating a lbaas v2
loadbalancer. This can be used to create a FIP.  This has a dependency
on a gophercloud PR: rackspace/gophercloud#606
@dkalleg
Copy link
Contributor Author

dkalleg commented Jul 7, 2016

Gates will fail until the aforementioned gophercloud PR merges and I update the vendor dir. Hoping to get some preliminary reviews to help get this into 0.7.0.

@dkalleg
Copy link
Contributor Author

dkalleg commented Aug 1, 2016

Giving an update here. The change this PR depends on was merged, but merged to gophercloud/gophercloud. Gophercloud is going through a refactor and a move from rackspace/gophercloud to gophercloud/gophercloud. rackspace/gophercloud is no longer taking changes, which means in order to use this PR, TF would have to shift from using rackspace/gophercloud to gophercloud/gophercloud. One the new gophercloud repo stabilizes, I'll be working on porting TF over to it and add it to this PR.

@jtopjian
Copy link
Contributor

jtopjian commented Aug 2, 2016

Hi @dkalleg!

Gophercloud is going through a refactor and a move from rackspace/gophercloud to gophercloud/gophercloud.

Indeed - this is on my radar and I've been reviewing the repo for changes.

One the new gophercloud repo stabilizes, I'll be working on porting TF over to it and add it to this PR.

You'll be working on porting the OpenStack provider to the new gophercloud repo or just this feature? If the former, I already have plans to do this. 😄

@dkalleg
Copy link
Contributor Author

dkalleg commented Aug 2, 2016

@jtopjian I meant to say that the gophercloud feature this PR depends on has merged, and will only merge, into the new gophercloud. And that I would work on bringing terraform over to the new gophercloud. If you're planning on doing that, then thats great! I'll leave it to you :)

Once that is complete I can rebase this PR and retest. No extra work should be needed to resolve the dependencies this PR. Thanks!

FYI, this is the commit I'm referring to, which enables VipPortID support: gophercloud/gophercloud@75801bc

@jtopjian
Copy link
Contributor

jtopjian commented Aug 3, 2016

@dkalleg 👍

I've opened up a dedicated issue for the Gophercloud migration: #7926. I didn't mean to imply do not attempt to move Terraform yourself! but more "hey, before we both duplicate a bunch of work!" 😄

If you work on the migration, definitely make notes in #7926 or if you find bugs in Gophercloud, definitely post them over there (even if it's just notes to the MIGRATING file).

@stack72 stack72 closed this in #9727 Nov 1, 2016
SebastianCzoch added a commit to SebastianCzoch/terraform that referenced this pull request Feb 13, 2019
@ghost
Copy link

ghost commented Apr 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants