Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/fastly: Update go-fastly SDK #7747

Merged
merged 2 commits into from
Jul 21, 2016
Merged

provider/fastly: Update go-fastly SDK #7747

merged 2 commits into from
Jul 21, 2016

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Jul 21, 2016

Update the go-fastly SDK to the latest version, fixing a bug when using ignore_if_set. b0022f5 adds ignore_if_set to an existing test, and will fail on master (at time of writing).

@catsby
Copy link
Contributor Author

catsby commented Jul 21, 2016 •
edited
Loading

Tried spinning up a custom TravisCI run for these tests, but TravisCI is having a blip, so I'm running them manual. Will update when they finish

TF_ACC=1 go test ./builtin/providers/fastly -v -run=TestAccFastly -timeout 120m
=== RUN   TestAccFastlyServiceV1CacheSetting_basic
--- PASS: TestAccFastlyServiceV1CacheSetting_basic (38.96s)
=== RUN   TestAccFastlyServiceV1_conditional_basic
--- PASS: TestAccFastlyServiceV1_conditional_basic (16.82s)
=== RUN   TestAccFastlyServiceV1_gzips_basic
--- PASS: TestAccFastlyServiceV1_gzips_basic (36.91s)
=== RUN   TestAccFastlyServiceV1_headers_basic
--- PASS: TestAccFastlyServiceV1_headers_basic (36.85s)
=== RUN   TestAccFastlyServiceV1RequestSetting_basic
--- PASS: TestAccFastlyServiceV1RequestSetting_basic (17.80s)
=== RUN   TestAccFastlyServiceV1_s3logging_basic
--- PASS: TestAccFastlyServiceV1_s3logging_basic (36.91s)
=== RUN   TestAccFastlyServiceV1_s3logging_s3_env
--- PASS: TestAccFastlyServiceV1_s3logging_s3_env (16.68s)
=== RUN   TestAccFastlyServiceV1_updateDomain
--- PASS: TestAccFastlyServiceV1_updateDomain (38.37s)
=== RUN   TestAccFastlyServiceV1_updateBackend
--- PASS: TestAccFastlyServiceV1_updateBackend (37.05s)
=== RUN   TestAccFastlyServiceV1_basic
--- PASS: TestAccFastlyServiceV1_basic (16.71s)
=== RUN   TestAccFastlyServiceV1_disappears
--- PASS: TestAccFastlyServiceV1_disappears (9.25s)
=== RUN   TestAccFastlyServiceV1_VCL_basic
--- PASS: TestAccFastlyServiceV1_VCL_basic (36.76s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/fastly 339.090s
Test:

UPDATE: https://travis-ci.org/hashicorp/terraform/builds/146411906 was the build I ran, it passed, yay

@catsby
Copy link
Contributor Author

catsby commented Jul 21, 2016

The tests pass and besides the dependency update, it's a minor change, so I'm going to pull this in.

@catsby catsby merged commit 9d88ad1 into master Jul 21, 2016
@catsby catsby deleted the f-update-fastly branch July 21, 2016 19:10
robinbowes added a commit to yo61/terraform that referenced this pull request Jul 25, 2016
@robinbowes
Merge branch 'master' into update_vmware-govcd
5a81e04 
* master: (34 commits)
  Update CHANGELOG.md
  provider/aws: Delete access keys before deleting IAM user (hashicorp#7766)
  Fix broken link to Consul demo (hashicorp#7789)
  provider/aws: `aws_redshift_cluster` `number_of_nodes` was having the (hashicorp#7771)
  provider/aws: Restore lost client.simpledbconn initialization
  Update vendored atlas client
  Make using `ssl_verify_mode` more robust (hashicorp#7769)
  Update CHANGELOG.md
  provider/aws: Rename the ECS Container Data Source test
  docs/azure: Small changes to remove the use of double
  Update docs to centralize on ARM-based Azure provider (hashicorp#7767)
  Update CHANGELOG.md
  Update CHANGELOG.md
  Add support for Kinesis streams shard-level metrics (hashicorp#7684)
  Update CHANGELOG.md
  Implementing aws_ami_launch_permission. (hashicorp#7365)
  Update CHANGELOG.md
  Add VersionString
  provider/aws: Set `storage_encrypted` to state in (hashicorp#7751)
  provider/fastly: Update go-fastly SDK (hashicorp#7747)
  ...
@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug provider/fastly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@catsby