provider/nomad: Nomad provider for managing jobs #9538

mitchellh · 2016-10-24T08:09:00Z

This adds a new provider nomad with a single resource nomad_job that can be used for managing jobs within a Nomad cluster.

The primary purpose for this provider is to manage system tasks or always-running service tasks that are used as part of cluster bootstrapping. For example, monitoring systems, core services, etc. Other jobs are usually submitted directly to Nomad (such as basic app deployment).

This is documented and tested (unit + acceptance). I rebased the commits so you can look at the provider/nomad commit to just see the provider separate from the vendoring.

Finally, this provider is built to work with Nomad 0.4.1. It likely won't work for earlier versions.

jamtur01 · 2016-10-24T08:22:38Z

builtin/providers/nomad/provider_test.go

+// How to run the acceptance tests for this provider:
+//
+// - Obtain an official Nomad release from https://nomadproject.io
+//   and extra "nomad" somewhere


extract? extract the nomad binary perhaps?

jamtur01 · 2016-10-24T08:24:56Z

builtin/providers/nomad/resource_job.go

+		log.Printf("[DEBUG] Deregistering job: %q", prevId)
+		_, _, err := client.Jobs().Deregister(prevId, nil)
+		if err != nil {
+			return fmt.Errorf("error deregistering previous job %q: %s", prevId, err)


previous feels odd here. error deregistering prior job would work? Or existing?

I don't want the user to be confused why we may be deregistering a job "foo" when the jobspec perhaps has job "bar". I've updated the wording to be a bit more explicit about that, pushing soon.

jamtur01 · 2016-10-24T08:30:43Z

website/source/docs/providers/nomad/index.html.markdown

+
+The following arguments are supported:
+
+* `address` - (Optional) The HTTP(S) API address of the agent to use. Defaults to "127.0.0.1:4646". `NOMAD_ADDR` can also be used.


The HTTP(S) API address of the Nomad agent to use - make it explicit to make it consistent.

I'd probably also: 127.0.0.1:4646.

jamtur01 · 2016-10-24T08:32:27Z

website/source/docs/providers/nomad/index.html.markdown

+
+The following arguments are supported:
+
+* `address` - (Optional) The HTTP(S) API address of the agent to use. Defaults to "127.0.0.1:4646". `NOMAD_ADDR` can also be used.


The "NOMAD_ADDR" environment can also be used.? WIth NOMAD_ADDR.

Ditto with the NOMAD_REGION line.

jamtur01 · 2016-10-24T08:34:05Z

website/source/docs/providers/nomad/r/job.html.markdown

+Manages a job registered in Nomad.
+
+This can be used to initialize your cluster with system jobs, common services,
+and more. In day to day Nomad use it is common for developers to submit


The second sentence doesn't make sense to me? I think I'm either missing a Nomad concept or it's a little convoluted?

jamtur01 · 2016-10-24T08:35:15Z

website/source/docs/providers/nomad/r/job.html.markdown

+
+```
+resource "nomad_job" "app" {
+    jobspec = "${file("${path.module}/job.hcl")}"


I doubt anyone is ever going to write a whole jobspec inline but maybe an example of a jobspec somewhere so folks know that it is they are looking for?

jamtur01 · 2016-10-24T08:37:20Z

builtin/providers/nomad/provider_test.go

@@ -11,7 +11,7 @@ import (
 // How to run the acceptance tests for this provider:
 //
 // - Obtain an official Nomad release from https://nomadproject.io
-//   and extra "nomad" somewhere
+//   and extra the "nomad" binary


Still missing the t :)

mitchellh · 2016-10-24T08:39:37Z

@jamtur01 Thanks! Addressed feedback (and fixed that typo), while adding more examples.

Apologies for the rebased push, I wouldn't normally do that but the history became a mess since I was missing dependencies. I'll address future feedback in normal commits and only rebase prior to merging.

jamtur01 · 2016-10-24T08:41:25Z

@mitchellh Very neat BTW! Does << EOT blah EOT work in HCL? I had no idea. I wonder if that's documented anywhere? I'll go look. :)

mitchellh · 2016-10-24T08:42:21Z

@jamtur01 Yes it does! You can even see it in "action" in the acceptance tests for this provider. It may not be documented actually... but I can do that separate from this PR.

jamtur01 · 2016-10-24T08:59:52Z

@mitchellh It's actually in the syntax docs already. Had just missed it! Thanks.

jen20 · 2016-10-24T14:57:21Z

@jamtur01 Yes - so does <<- to remove hanging indent (à la Ruby)

apparentlymart · 2016-10-24T15:20:33Z

I was looking at #8769 primarily so that Terraform could interface with Nomad in a way that doesn't defeat Nomad's own diffing mechanism.

Certainly not meaning to suggest that this has to be blocked by #8769, but just wanted to point it out in case it helps to think about 1) whether such behavior is desirable anyway, and 2) assuming yes, whether adding it later would require a breaking change here that might make it worth tweaking the design now. (I think probably not, but I'm not 100% sure...)

mitchellh · 2016-10-24T15:51:26Z

@apparentlymart I think in Nomad's cause that would be nice but doesn't block it since Nomad is idempotent. If you make a stylistic change that causes a plan to update the job, Nomad won't actually do anything once the job is resubmitted. I think that makes this okay.

jamtur01 · 2016-10-24T16:45:09Z

@jen20 Do you mean <<~ (that removes hanging indent in Ruby - <<- preserves whitespace.

ghost · 2020-04-20T02:09:07Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

mitchellh added enhancement new-provider labels Oct 24, 2016

jamtur01 reviewed Oct 24, 2016

View reviewed changes

mitchellh force-pushed the f-nomad-provider branch from d7be1de to 90991b3 Compare October 24, 2016 08:39

mitchellh added 2 commits October 24, 2016 10:33

vendor: Nomad

8af241e

provider/nomad

bb5f649

mitchellh force-pushed the f-nomad-provider branch from 9b4e35b to bb5f649 Compare October 24, 2016 17:34

apparentlymart mentioned this pull request Nov 5, 2016

Feature request: nomad provider #8952

Closed

nicolai86 mentioned this pull request Nov 6, 2016

new feature: add nomad provider/resource (to run jobs thru nomad) #4442

Closed

providers/nomad: suppress diff for identical jobspecs

f35996c

mitchellh merged commit fd498fb into master Nov 10, 2016

mitchellh deleted the f-nomad-provider branch November 10, 2016 02:34

asobrien mentioned this pull request Feb 1, 2017

terraform linux_arm builds unusable (versions >= 0.8.0) #11507

Closed

ghost locked and limited conversation to collaborators Apr 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

provider/nomad: Nomad provider for managing jobs #9538

provider/nomad: Nomad provider for managing jobs #9538

mitchellh commented Oct 24, 2016

jamtur01 Oct 24, 2016

jamtur01 Oct 24, 2016 •

edited

Loading

mitchellh Oct 24, 2016

jamtur01 Oct 24, 2016

jamtur01 Oct 24, 2016

jamtur01 Oct 24, 2016

jamtur01 Oct 24, 2016

jamtur01 Oct 24, 2016

jamtur01 Oct 24, 2016

mitchellh commented Oct 24, 2016 •

edited

Loading

jamtur01 commented Oct 24, 2016

mitchellh commented Oct 24, 2016

jamtur01 commented Oct 24, 2016

jen20 commented Oct 24, 2016

apparentlymart commented Oct 24, 2016

mitchellh commented Oct 24, 2016

jamtur01 commented Oct 24, 2016

ghost commented Apr 20, 2020


		The following arguments are supported:

		* `address` - (Optional) The HTTP(S) API address of the agent to use. Defaults to "127.0.0.1:4646". `NOMAD_ADDR` can also be used.

provider/nomad: Nomad provider for managing jobs #9538

provider/nomad: Nomad provider for managing jobs #9538

Conversation

mitchellh commented Oct 24, 2016

Choose a reason for hiding this comment

jamtur01 Oct 24, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mitchellh commented Oct 24, 2016 • edited Loading

jamtur01 commented Oct 24, 2016

mitchellh commented Oct 24, 2016

jamtur01 commented Oct 24, 2016

jen20 commented Oct 24, 2016

apparentlymart commented Oct 24, 2016

mitchellh commented Oct 24, 2016

jamtur01 commented Oct 24, 2016

ghost commented Apr 20, 2020

jamtur01 Oct 24, 2016 •

edited

Loading

mitchellh commented Oct 24, 2016 •

edited

Loading