Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finalize! not called for configuration objects if its key is not used in Vagrantfile #1877

Closed
tmatilai opened this issue Jun 27, 2013 · 2 comments
Closed

finalize! not called for configuration objects if its key is not used in Vagrantfile #1877

tmatilai opened this issue Jun 27, 2013 · 2 comments

Comments

@tmatilai
Copy link
Contributor

It seems that if there is no configuration for an object in Vagrantfiles, the finalize! method is never called for them. This is a problem for plugins that want to set default configuration in the said method. Thus the values are left to UNSET_VALUE (or what the constructor set).
@mitchellh
Copy link
Contributor

Yeah this seems like a good bug. Will investigate. Thanks!

@tmatilai tmatilai mentioned this issue Jun 27, 2013
Merged
mitchellh added a commit that referenced this issue Jul 23, 2013
@mitchellh
Unused config objects are finalized properly [GH-1877]
7ef6c5d
@mitchellh
Copy link
Contributor

Fixed, will be part of 1.2.5.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitchellh @tmatilai