-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configure_disks.rb #13346
Update configure_disks.rb #13346
Conversation
fixed configure_disks.rb in hyper-v capabilities provider to allow creation and removal of additional disks,
Added double splat to created_disk and attach_disk invocations to explicitly allow the implicit conversions disabled in Ruby 3.x. |
Dear mantainers, can we proceed with workflows approval? can you enable me to run workflows needed for final review? Best regards. Camillo |
Camillo - appreciate you sharing this fix... hopefully it gets reviewed and merged soon. |
Dear Paul - Thank you. Have you any news about any incoming review? |
No. I'm not a maintainer, just a user.
…On Tue, Apr 16, 2024, 06:45 Camillo Toselli ***@***.***> wrote:
Dear Paul - Thank you. Have you any news about any incoming review?
—
Reply to this email directly, view it on GitHub
<#13346 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AU3TQYUUPOCWMPG7TVFYJSLY5UTNXAVCNFSM6AAAAABCQ674V2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZGEZTCOBVHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for this PR and my apologies for the delay in getting reviewed and merged! |
Thank you so much! Camillo |
fixed configure_disks.rb in hyper-v capabilities provider to allow creation and removal of additional disks,