Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configure_disks.rb #13346

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Update configure_disks.rb #13346

merged 2 commits into from
Jul 11, 2024

Conversation

camillo-toselli
Copy link
Contributor

fixed configure_disks.rb in hyper-v capabilities provider to allow creation and removal of additional disks,

fixed configure_disks.rb in hyper-v capabilities provider to allow creation and removal of additional disks,
@hashicorp-cla
Copy link

hashicorp-cla commented Jan 30, 2024

CLA assistant check
All committers have signed the CLA.

@camillo-toselli
Copy link
Contributor Author

Added double splat to created_disk and attach_disk invocations to explicitly allow the implicit conversions disabled in Ruby 3.x.
This fix makes the creation and removal of disks by the hyper-v provider start working again.

@camillo-toselli
Copy link
Contributor Author

Dear mantainers,

can we proceed with workflows approval? can you enable me to run workflows needed for final review?
These simple changes make hyperv disk configuration work correctly also on Ruby 3.xx.
Thanks in advance,

Best regards.

Camillo

@PaulNacamuli
Copy link

Camillo - appreciate you sharing this fix... hopefully it gets reviewed and merged soon.

@camillo-toselli
Copy link
Contributor Author

Dear Paul - Thank you. Have you any news about any incoming review?

@PaulNacamuli
Copy link

PaulNacamuli commented Apr 17, 2024 via email

Copy link
Member

@chrisroberts chrisroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chrisroberts
Copy link
Member

Thanks for this PR and my apologies for the delay in getting reviewed and merged!

@chrisroberts chrisroberts merged commit 015e050 into hashicorp:main Jul 11, 2024
12 checks passed
@camillo-toselli
Copy link
Contributor Author

Thank you so much!

Camillo

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants