Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding warning for IPv6 ending with 1 #13362

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

chadek
Copy link
Contributor

@chadek chadek commented Mar 9, 2024

After struggling quite some time I figured out I had an issue caused by setting an IPv6 ending with :1

The network_ip_ends_in_one warning message is use for IPv4 to warn user about this matter, I would like to add this warning to IPv6 to avoid some painful debug time to future IPv6 users

Signed-off-by: Fabrice Meyer <meyer.fabrice@gmx.fr>
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 9, 2024

CLA assistant check
All committers have signed the CLA.

@chadek
Copy link
Contributor Author

chadek commented Mar 27, 2024

Will this MR go further?

Copy link
Member

@chrisroberts chrisroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chrisroberts chrisroberts merged commit 0c328c3 into hashicorp:main Jul 10, 2024
2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants