Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More reliable Ubuntu and Debian guest detection #1685

Conversation

fgrehm
Copy link
Contributor

@fgrehm fgrehm commented May 2, 2013

When dealing with lxc containers, '/proc/version' will have information about the host machine kernel that can possibly have information about an Ubuntu / Debian host, messing up with guest container detection.

When dealing with lxc containers, '/proc/version' will have information
about the host machine kernel that can possibly have information about
an Ubuntu / Debian host, messing up with guest container detection.
@fgrehm
Copy link
Contributor Author

fgrehm commented May 2, 2013

@mitchellh I'm not sure how clear the problem is to you so here goes an example: I'm on a Ubuntu machine, trying to use vagrant-lxc to manage a CentOS container, because my /proc/version contains "Ubuntu" in it, Vagrant will end up adding Ubuntu on the guest object chain.

@mitchellh
Copy link
Contributor

Looks great. Merging. Thanks!

mitchellh added a commit that referenced this pull request May 2, 2013
…guest-detection

More reliable Ubuntu and Debian guest detection
@mitchellh mitchellh merged commit f84b87d into hashicorp:master May 2, 2013
@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants