Fixed broken PowerShell execution #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks right. Sorry about that! |
mitchellh
added a commit
that referenced
this pull request
Mar 14, 2014
core: Fixed broken PowerShell execution
This was referenced Mar 17, 2014
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 621369e which is supposed to fix issue #3100 actually seems to break execution completely. While trying to solve #3139 I encountered the same problem as in #3192 where the JSON couldn't be parsed.
I dumped stdout from the process into a file (
File.write("C:/test.txt", r.stdout)) and the output was the path to the actual script and not the generated JSON. It seems like wrapping the path in single quotation marks just passes it as a string to PowerShell, who have no clue what to do and just throws the string back at you.I did a quick search and proper way to execute scripts with "spaced paths" seems to be this way. This commit should fix the problem encountered in #3192 and actually fix #3100.