Support configuring all Vault connection details in flags #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvoran
approved these changes
Feb 8, 2022
|
Is there any documentation on how to set these flags, especially when installing via the helm chart??? It does not look like the helm chart was updated to support these new flags in a nice, clear way. |
|
@brettjacobson thanks for raising this question. Generally speaking, most of these flags are designed to be used via I also raised another PR to improve the documentation on our website: hashicorp/vault#15810 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82
Adds flags to configure Vault TLS and namespace settings in addition to the existing options to use environment variables and SPC parameters. We already allowed using env vars due to using
api.DefaultConfig(), but hadn't actually documented this anywhere. Config precedence follows the level of specificity, so SPC > flag > env var.I also replaced usage of this repo's
config.TLSConfigwith the Vault API module'sapi.TLSConfig, which is the same struct with slightly different member names.