Support JWT auth #210
Merged
Support JWT auth #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschoche
approved these changes
Apr 27, 2023
kschoche
reviewed
Apr 27, 2023
| parameters.VaultKubernetesMountPath = params["vaultKubernetesMountPath"] | ||
| k8sMountPath, k8sSet := params["vaultKubernetesMountPath"] | ||
| authMountPath, authSet := params["vaultAuthMountPath"] | ||
| switch { |
There was a problem hiding this comment.
I've never seen this pattern of using switch statements this way in golang before, really cool!
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone pointed out that JWT auth already works because the login endpoints are identical for kubernetes and JWT. This just improves the naming and adds an integration test for the purpose of regression testing so that we can officially document JWT auth as supported.