Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress does not work with GCE ingress controller on GKE #190

Closed
amkartashov opened this issue Jan 31, 2020 · 2 comments
Closed

Ingress does not work with GCE ingress controller on GKE #190

amkartashov opened this issue Jan 31, 2020 · 2 comments
Labels
chart Area: helm chart enhancement New feature or request

Comments

@amkartashov
Copy link

Ingress events:

$ kubectl  -n vault describe ing vault
...
Events:
  Type     Reason             Age                     From                     Message
  ----     ------             ----                    ----                     -------
  Normal   ADD                9m49s                   loadbalancer-controller  vault/vault
  Normal   CreateCertificate  9m49s                   cert-manager             Successfully created Certificate "vault-tls"
  Warning  Sync               3m19s (x17 over 9m45s)  loadbalancer-controller  Error during sync: error running backend syncing routine: googleapi: Error 400: Invalid value for field 'resource.timeoutSec': '5'. TimeoutSec should be less than checkIntervalSec., invalid

GCE ingress controller tries to create healthchecks for GCLB which has strict requirement for timeout be less than check interva, see https://cloud.google.com/load-balancing/docs/health-checks and https://github.com/kubernetes/ingress-gce/blob/master/docs/faq/gce.md#can-i-configure-gce-health-checks-through-the-ingress

Unfortunately values for checking interval (periodSeconds) and check timeout (timeoutSeconds) are hardcoded here https://github.com/hashicorp/vault-helm/blob/master/templates/server-statefulset.yaml#L108 and there is no way to fix this without forking helm chart.

@tvoran tvoran added chart Area: helm chart enhancement New feature or request labels Feb 1, 2020
@karthikm83
Copy link

+1:

This is a bug and should be fixed. Either these values should be left to default or configurable through values.yaml

It makes sense that periodSeconds should be higher than timeoutSeconds

periodSeconds: How often (in seconds) to perform the probe. Default to 10 seconds. Minimum value is 1.

timeoutSeconds: Number of seconds after which the probe times out. Defaults to 1 second. Minimum value is 1.

@jasonodonnell
Copy link
Contributor

We've made all these values configurable: #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart Area: helm chart enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants