Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow also yaml configuration for nodeSelector, tolerations and affinities #380

Closed
FWest98 opened this issue Aug 31, 2020 · 5 comments
Closed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@FWest98
Copy link

FWest98 commented Aug 31, 2020

Similar to #272 (and somewhat also #213 ), it would be great to add support for using yaml instead of a string to configure the tolerations, affinity, and nodeSelector for the various components (injector, server). This would also be in line with how this is done in many other popular charts (which then ties in to #55 ).

@FWest98 FWest98 added the enhancement New feature or request label Aug 31, 2020
@jasonodonnell
Copy link
Contributor

jasonodonnell commented Apr 20, 2021

I believe these are all supported, so closing this ticket. Feel free to reopen if you think I made an error!

@erks
Copy link

erks commented Apr 28, 2021

{{ tpl .Values.server.affinity . | nindent 8 | trim }}
I don't see these fields supporting YAML yet on master. We still need to use string here. Can you reopen?

@FWest98
Copy link
Author

FWest98 commented May 3, 2021

I am not sure if I see what was changed in this. According to the docs all nodeSelector, tolerations, and affinities fields still require a multiline string instead of a yaml object. A quick look into the code reveals no clues that this has changed.

Could you maybe clarify what you changed to incorporate this?

@jasonodonnell jasonodonnell reopened this May 3, 2021
@jasonodonnell
Copy link
Contributor

My apologies, just misremembering. We added YAML support for a lot of other configurables, but missed these. We'll get these added.

@tvoran tvoran added the good first issue Good for newcomers label Jun 30, 2021
@benashz
Copy link
Contributor

benashz commented Jul 7, 2021

Fixed in #565

@benashz benashz closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants