Making all annotations multi-line strings #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annotations for various objects were either multi-line strings or yaml maps strings, so this is making them all multi-line strings for consistency. Also updated the doc comment for namespaceSelector, since it's being read as a yaml map (toYaml).
jasonodonnell
approved these changes
Mar 20, 2020
|
Why would you do a multi-line string instead of a yaml hash for this? This is the "standard" used in pretty much any helm chart I've seen. |
|
I think the main reason is that a multi-line string can be run through In any case, this PR was just about making annotations consistent within the chart. |
|
I guess that makes sense for people using helm directly. I'm using Either way, I'll discuss this more in #55. |
kri5
added a commit
to kri5/vault-helm
that referenced
this pull request
Apr 15, 2020
It has been decided in hashicorp#227 to move annotations to multi-line string for consistency. Thoses definitions were not following thoses rules. This commit fixes it.
radudd
pushed a commit
to radudd/vault-helm
that referenced
this pull request
Jun 5, 2020
Annotations for various objects were either multi-line strings or yaml maps strings, so this is making them all multi-line strings for consistency. Also updated the doc comment for namespaceSelector, since it's being read as a yaml map (toYaml).
hadielaham88
pushed a commit
to SolaceDev/vault-helm
that referenced
this pull request
May 19, 2021
Annotations for various objects were either multi-line strings or yaml maps strings, so this is making them all multi-line strings for consistency. Also updated the doc comment for namespaceSelector, since it's being read as a yaml map (toYaml).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotations for various objects were either multi-line strings or yaml
maps strings, so this is making them all multi-line strings for
consistency. Also updated the doc comment for namespaceSelector, since
it's being read as a yaml map (toYaml).
Relates to #117