Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting VAULT_RAFT_NODE_ID environment variable #269

Merged
merged 3 commits into from
Apr 27, 2020
Merged

Add support for setting VAULT_RAFT_NODE_ID environment variable #269

merged 3 commits into from
Apr 27, 2020

Conversation

lawliet89
Copy link
Contributor

@lawliet89 lawliet89 commented Apr 21, 2020 •
edited
Loading

Gives raft nodes more meaningful names than some randomly generated UUID.

@tvoran tvoran added chart Area: helm chart enhancement New feature or request labels Apr 22, 2020
@jasonodonnell jasonodonnell self-requested a review April 27, 2020 15:38
jasonodonnell
jasonodonnell approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@jasonodonnell jasonodonnell merged commit 8cc3fdb into hashicorp:master Apr 27, 2020
@lawliet89 lawliet89 deleted the raft-node-id branch April 28, 2020 02:10
@tvoran tvoran added this to the v0.6.0 milestone May 22, 2020
radudd pushed a commit to radudd/vault-helm that referenced this pull request Jun 5, 2020
@lawliet89
Add support for setting VAULT_RAFT_NODE_ID environment variable (hash…
97180df 
…icorp#269)

* Add support for setting VAULT_RAFT_NODE_ID environment variable

* Update server-statefulset.yaml

* Update server-ha-statefulset.bats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonodonnell jasonodonnell jasonodonnell approved these changes

Assignees
No one assigned
Labels
chart Area: helm chart enhancement New feature or request
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lawliet89 @jasonodonnell @tvoran