-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix annotation bug. Use active service on ingress when ha #270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch! I think this needs a test, and the defaults for annotations should be left as they are.
I'm also wondering if the service type should be configurable for the active and standby services, since it's set to ClusterIP now.
fix a missing : revert values as requested
I've reverted the annotations as requested and actually corrected a mistake in the serviceName. It prints as expected using helm template and helm lint. Not sure how to automate this test on here. p.s. the force pushes were just to squash the commits |
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Added some logic that points the ingress at the active server when in ha mode. There are times that pointing at the standby pods causes problems.
Annotations currently give a warning because they are not actually rendering as yaml like normal charts do.
"Warning: Merging destination map for chart 'vault'. Cannot overwrite table item 'annotations', with non table value: map[]"
changing from annotations: {} to annotations: [] removes this warning.
Additionally I've added some logic that points the ingress at the active server when in ha mode. There are times that pointing at the standby pods causes problems.