Add configuration options for Vault UI service #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lawliet89
commented
May 4, 2020
lawliet89
commented
- Configure to select active Vault pod only
- Configure to not publish unready address
- Configure to select active Vault pod only - Configure to not publish unready address
templates/ui-service.yaml
Outdated
| @@ -23,7 +18,10 @@ spec: | |||
| app.kubernetes.io/name: {{ include "vault.name" . }} | |||
| app.kubernetes.io/instance: {{ .Release.Name }} | |||
| component: server | |||
| publishNotReadyAddresses: true | |||
| {{- if .Values.ui.activeVaultPodOnly }} | |||
There was a problem hiding this comment.
This is only true if in HA mode. I think we don't even need a configurable here. If it's HA mode, just set the selector criteria, else point to the single deployed pod.
Thoughts?
There was a problem hiding this comment.
I can add an additional condition to check that HA mode is on.
I think this should be configurable to handle other possible use cases like #326. What do you think? I could remove this option if you think otherwise.
There was a problem hiding this comment.
I think configurable is fine.
There was a problem hiding this comment.
I've added the check for HA in 956b101
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.