Add more config variables for transit-unsealing and raft-joining #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Vault configuration (
/tmp/storageconfig.hcl
) only providesHOST_IP
andPOD_IP
as variables that get replaced. Additionally, the usedsed
commands are not well written and can not support entering URLs (or anything that contains a/
).This two variables are not enough to set up Vault correctly in all scenarios (in HA you need
API_ADDR
). For unsealing with Vault Transit (docs) you also need to configure the address of another Vault server (eg.TRANSIT_ADDR
). And to set up Raft backend (docs) as easy as possible it is beneficial, that all nodes attempt to automatically join the cluster (eg.RAFT_ADDR
). With this PR these can all be set as environment variables underextraEnvironmentVars:
and this enables you to utilize variables in Helmfile (or other wrappers on top of Helm).Anyway, I have been successfully using and redeploying Vault with transit-unsealing and raft-joining for a couple of months now with this PR and such a configuration: