add support for more flexible volume mounts e.g. for use with init containers #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonodonnell
suggested changes
May 27, 2020
|
Hi Jason. I'll try, I've not used these before so might have questions. I've tested the output is as expected using |
georgekaz
force-pushed
the
support-init-containers
branch
from
a0a10b7 to
b900fa7
Compare
…or init container add unit tests add missing braces
georgekaz
force-pushed
the
support-init-containers
branch
from
4675c64 to
060ea1f
Compare
|
@jasonodonnell Can this be merged, please? |
jasonodonnell
approved these changes
Jul 14, 2020
This was referenced Jul 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing volume mounts implementation via extraVolumes is too opinionated to allow mounting volumes for custom purposes, such as installing a plugin via an init container. Personally I don't like it and would remove it completely, but for backwards compatibility I've left it and added additional server.volumes and server.volumeMounts. Examples in the values files show how this can be used.
Please consider this as it's an easy way to customise your Vault installation.