Allow setting HA services type #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making the types for active and standby services configurable (just like the main vault service).
radudd
pushed a commit
to radudd/vault-helm
that referenced
this pull request
Jun 5, 2020
Making the types for active and standby services configurable (just like the main vault service).
|
@tvoran, @jasonodonnell Doesn't this force us to use a |
|
Yes, if you're running with |
|
I'm using DynamoDB as storage and seems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the types for active and standby services configurable (just
like the main vault service).
When ha and ingress are enabled in the chart, Ingress uses the
vault-activeservice, which is currently a ClusterIP service. The trouble is, Ingress on GKE doesn't support ClusterIP services, so the service type needs to be configurable to work there.