Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tolerate-unready-endpoints annotation #363

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

tongpu
Copy link
Contributor

@tongpu tongpu commented Jul 28, 2020

This annotation has been deprecated since Kuberneets 1.8 and the publishNotReadyAddresses parameter replacing it has been correctly implemented in Kubernetes 1.11 (see kubernetes/kubernetes#63742)

This annotation has been deprecated since Kuberneets 1.8 and the
publishNotReadyAddresses parameter replacing it has been correctly
implemented in Kubernetes 1.11 (see kubernetes/kubernetes#63742)
@hashicorp-cla
Copy link

hashicorp-cla commented Jul 28, 2020

CLA assistant check
All committers have signed the CLA.

@jasonodonnell jasonodonnell self-requested a review July 30, 2020 14:17
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tongpu !

@jasonodonnell jasonodonnell merged commit ec69e1c into hashicorp:master Jul 30, 2020
@jasonodonnell jasonodonnell mentioned this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants