Make serviceAccount name a configuration option #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow Helm Best Practices when defining serviceAccount names https://helm.sh/docs/chart_best_practices/#using-rbac-resources
|
|
|
@jasonodonnell I've fixed the tests, but CLA on @davidholsgrove side seems to be a blocker now. 😢 |
|
Apologies, working through approvals to sign the CLA at the moment. Happy for anyone to take over and get this merged if that's an option too. |
Co-authored-by: David Holsgrove <david@apnic.net>
to address hashicorp#56 (review) Co-authored-by: David Holsgrove <david@apnic.net>
Co-authored-by: David Holsgrove <david@apnic.net>
burningalchemist
force-pushed
the
service-account-name
branch
from
0d1d9ad
to
2bb7c9a
Compare
tvoran
reviewed
Aug 15, 2020
|
Hi @tvoran ! Thanks for your review, please take a look, whenever you have time. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #338 with fixed tests to finally bring the feature to the chart.