Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow server annotations with dev mode #371

Merged
merged 1 commit into from
Aug 20, 2020
Merged

allow server annotations with dev mode #371

merged 1 commit into from
Aug 20, 2020

Conversation

banthaherder
Copy link
Contributor

Reconciles issues seen in #301

As a developer I would like to be able to use dev mode in conjunction with pod annotations.

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 10, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jasonodonnell jasonodonnell self-requested a review August 20, 2020 17:44
jasonodonnell
jasonodonnell approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jasonodonnell jasonodonnell merged commit f40cc89 into hashicorp:master Aug 20, 2020
@tvoran tvoran mentioned this pull request Aug 20, 2020
Closed
@jasonodonnell jasonodonnell mentioned this pull request Aug 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonodonnell jasonodonnell jasonodonnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@banthaherder @hashicorp-cla @jasonodonnell