Update notes template to be helm v3 compatible #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`helm get {{ .Release.Name }}` is replaced by `vault get all {{ .Release.Name }}` in helm v3, but `all` doesn't exist in v2.
jasonodonnell
approved these changes
Aug 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helm get {{ .Release.Name }}is replaced byhelm get all {{ .Release.Name }}in helm v3, butalldoesn't exist in v2. In v3, runninghelm get vaultreturns the help text.In this PR I've proposed changing to
vault get manifestbecause that's an example that works on both versions without having to write a caveat with two versions of the command, and contains the additional information that I think most new users would be immediately interested in. But I'm not opposed to giving two versions of the command either.v2 docs: https://v2.helm.sh/docs/helm/#helm-get
v3 docs: https://helm.sh/docs/helm/helm_get/