Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Raft config provided in YAML #406

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gw0
Copy link
Contributor

@gw0 gw0 commented Oct 21, 2020

According to the improvement in #213 I attempted to use YAML config in Raft mode. It turns out, that the type check in this situation does not work correctly.

  ha:
    enabled: true
    #config: {}  # uncomment as a workaround for this bug (#406) to provide the correct type
    raft:
      enabled: true
      config:
        ...(yaml config)...

Results in:

Error: template: vault/templates/server-config-configmap.yaml:26:18: executing "vault/templates/server-config-configmap.yaml" at <.Values.server.ha.raft.config>: wrong type for value; expected string; got map[string]interface {}

@jasonodonnell jasonodonnell self-requested a review December 7, 2020 15:44
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @gw0, good catch on this bug. It seems this broke a bunch of unit tests, though?

@gw0
Copy link
Contributor Author

gw0 commented Dec 7, 2020

Yeah, I did not manually run the unit tests and I do not want to log into CircleCI in order to see the details of what is failing.

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants