injector: add templateConfig.exitOnRetryFailure annotation #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
commented
Jun 30, 2021
tvoran
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
Can you also add this to the json schema? https://github.com/hashicorp/vault-helm/blob/master/test/README.md#generating-the-values-json-schema
benashz
approved these changes
Jul 5, 2021
illegalnumbers
pushed a commit
to streamnative/vault-helm
that referenced
this pull request
Mar 17, 2022
…#560) * injector: add templateConfig.exitOnRetryFailure annotation * update values.schema.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
templateConfig.exitOnRetryFailureannotation to the Helm chart in order to make the new parameter introduced in hashicorp/vault-k8s#267 globally configurable.We should hold off on merging this until the next vault-k8s release that contains the new param on agent-inject has shipped though.