Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the default vault agent image to come from the hashicorp docker organization. #567

Merged
merged 4 commits into from
Jul 12, 2021
Merged

Update the default vault agent image to come from the hashicorp docker organization. #567

merged 4 commits into from
Jul 12, 2021

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Jul 9, 2021

This PR includes:

  • update the default vault agent image to come from the hashicorp docker organization.
  • add support for running the acceptance tests against a local kind cluster.

@benashz
Add support for running acceptance tests against a kind cluster
92586d4 
* make the injector-leader-elector a bit more reliable when run locally
@benashz benashz force-pushed the benashz/vault-1466-use-hashicorp-vault-agent-image branch from f79f9eb to 92586d4 Compare July 10, 2021 00:18
tvoran
tvoran reviewed Jul 10, 2021
View reviewed changes
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind splitting this into two PRs? The default image changes and the kind cluster work seem to be unrelated.

test/README.md Outdated Show resolved Hide resolved
values.yaml Show resolved Hide resolved
tomhjp
tomhjp approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@benashz benashz merged commit 2d42085 into master Jul 12, 2021
@benashz benashz deleted the benashz/vault-1466-use-hashicorp-vault-agent-image branch July 12, 2021 17:08
@tvoran tvoran mentioned this pull request Jul 28, 2021
Merged
illegalnumbers pushed a commit to streamnative/vault-helm that referenced this pull request Mar 17, 2022
@benashz @illegalnumbers
Update the default vault agent image to come from the hashicorp docke…
79764ef 
…r organization. (hashicorp#567)

* Default to hashicorp/vault for vault agent image.

* Add support for running acceptance tests against a kind cluster

* make the injector-leader-elector a bit more reliable when run locally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvoran tvoran tvoran left review comments

@tomhjp tomhjp tomhjp approved these changes

@jasonodonnell jasonodonnell Awaiting requested review from jasonodonnell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benashz @tvoran @tomhjp