Add ingress/route configurable to specify active/general service #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benashz
reviewed
Jul 15, 2021
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
benashz
approved these changes
Jul 15, 2021
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- if .Values.global.openshift }} |
There was a problem hiding this comment.
Seems to be quite a bit of whitespace change, dos2unix :)
There was a problem hiding this comment.
It does look strange, doesn't it?
There was a problem hiding this comment.
Looks like we had DOS line feeds. Seems to have been the only file affected.
$ git ls-files -z | xargs -0 file|grep CRLF
templates/server-route.yaml: ASCII text, with CRLF line terminators
illegalnumbers
pushed a commit
to streamnative/vault-helm
that referenced
this pull request
Mar 17, 2022
…hicorp#570) * Add ingress/route configurable to specify active/general service * Update test/unit/server-ingress.bats Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com> * values.schema.json Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using ingress/routes, if HA mode is enabled, these services will always point to the active service. There are use cases, such as performance standbys, where the ingress should instead point to the general Vault service instead.
This adds two new boolean configs
server.ingress.activeServiceandserver.route.activeServiceto make this configurable.